[3.0] Move to dedicated Hooks table#8808
Open
jdarwood007 wants to merge 16 commits intoSimpleMachines:release-3.0from
Open
[3.0] Move to dedicated Hooks table#8808jdarwood007 wants to merge 16 commits intoSimpleMachines:release-3.0from
jdarwood007 wants to merge 16 commits intoSimpleMachines:release-3.0from
Conversation
Sets up a dedicated hooks table for our integrations. Deprecates using modSettings to store integrations. Deprecates integrate_ prefix to hook names Adds compatibility with SMF 2.1 logic.
live627
reviewed
Jul 26, 2025
live627
reviewed
Jul 26, 2025
live627
reviewed
Jul 26, 2025
live627
reviewed
Jul 26, 2025
Sesquipedalian
requested changes
Aug 7, 2025
# Conflicts: # Sources/Actions/Admin/Maintenance.php # Sources/IntegrationHook.php
# Conflicts: # Sources/Config.php
Oldiesmann
reviewed
Sep 27, 2025
Co-authored-by: John Rayes <live627@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets up a dedicated hooks table for our integrations. Hooks have become very important to our code base to ensure our mod authors are able to tap into the code where needed without needing to alter the source code. As such we should build a more efficient setup for storing and maintaining those hooks.
integrate_prefix to hook namesI have toyed with the idea of fully removing all
integrate_from all files. Not sure if it's relevant to this PR. But since we are now storing hooks in their table, we don't need to have the prefix. Looking for any feedback on that, I am thinking it should be done and let the IntegrationHooks logic handle restoring it for compatibility with SMF 2.1 where needed.I need to do more testing here as this changes a lot and I have only done some basic mod tests.