return GSPGroup while reverse-geocoding to GSP

[Herald-TUOS]

No description provided.

[JamieTaylor-TUOS]

Not sure what the if condition is for? won't this always evaluate to True?

[Herald-TUOS]

This won't be True when reverse geo-coding llsoa and nuts

[JamieTaylor-TUOS]

I don't think its desirable to sometime return a list of strings and other times to return a list of tuples. I think we should always return a list of tuples, or else introduce a parameter to determine whether to return the GSPGroup or not (though the latter smells a little)

[Herald-TUOS]

Since llsoa and nuts doesn't need to return a list of tuples, I think we should come up with something else. Is it okay to make a separate function for reverse geo-coding gsp?

[Herald-TUOS]

Any idea why these tests are failing @JamieTaylor-TUOS ?
They are succeeding locally.

(geocode) ph1ho@phy13076:~/Documents/Geocode$ git checkout 61-return-gsps-and-gspgroups-after-reverse-geocoding 
Switched to branch '61-return-gsps-and-gspgroups-after-reverse-geocoding'
Your branch is up-to-date with 'origin/61-return-gsps-and-gspgroups-after-reverse-geocoding'.
(geocode) ph1ho@phy13076:~/Documents/Geocode$ pytest Tests/
=================================================================================== test session starts ====================================================================================
platform linux -- Python 3.10.12, pytest-8.3.4, pluggy-1.5.0
rootdir: /home/ph1ho/Documents/Geocode
plugins: requests-mock-1.11.0, anyio-4.8.0, cov-6.0.0, mock-3.14.0
collected 9 items                                                                                                                                                                          

Tests/test_geocode.py .........                                                                                                                                                      [100%]

===================================================================================== warnings summary =====================================================================================
Tests/test_geocode.py::geocodeTestCase::test_geocode_postcode
  /home/ph1ho/Documents/Geocode/geocode/cpo.py:163: FutureWarning: The provided callable <function nanmean at 0x77a1d6351e10> is currently using SeriesGroupBy.mean. In a future version of pandas, the provided callable will be used directly. To keep current behavior pass the string "mean" instead.
    results_.groupby("id")

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
========================================================================= 9 passed, 1 warning in 126.35s (0:02:06) =========================================================================
(geocode) ph1ho@phy13076:~/Documents/Geocode$ python3 --version
Python 3.13.2