Skip to content

Fix #117 : Timestamp required for all Sparkplug B Version 3 metrics.#119

Open
thomassorensen2650 wants to merge 2 commits intoSeppPenner:masterfrom
thomassorensen2650:master
Open

Fix #117 : Timestamp required for all Sparkplug B Version 3 metrics.#119
thomassorensen2650 wants to merge 2 commits intoSeppPenner:masterfrom
thomassorensen2650:master

Conversation

@thomassorensen2650
Copy link

@thomassorensen2650 thomassorensen2650 commented Feb 22, 2025

This PR is to address #117 and the requirement for all Sparkplug B Version 3.0.0 metrics to have a timestamp added.

Requirement:
https://github.com/eclipse-sparkplug/sparkplug/blob/e45b61002a2a0cacb4f11fa4be88670435ccfcb0/specification/src/main/asciidoc/chapters/Sparkplug_6_Payloads.adoc?plain=1#L475C1-L476C97

Changes:

  1. All Sparkplug B Version 3 metrics without timestamp will now get the message timestamp assigned.
  2. added unit test for 1.
  3. Fixed a type error in SparkplugPayloadConverterTestVersionB to ensure all test can now pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant