Skip to content

Support for Less v4#76

Open
ninjascribble wants to merge 9 commits intoSemantic-Org:masterfrom
LiquidPlanner:master
Open

Support for Less v4#76
ninjascribble wants to merge 9 commits intoSemantic-Org:masterfrom
LiquidPlanner:master

Conversation

@ninjascribble
Copy link

less v4 introduces some breaking changes which this PR addresses.

@headerDisplay: block;
@headerDistance: 0rem;
@headerMargin: -@headerLineHeightOffset 0em @headerDistance 0em;
@headerMargin: calc(-1 * @headerLineHeightOffset) 0em @headerDistance 0em;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this calc() here on purpose?

/* Result Content */
@resultTitleFont: @headerFont;
@resultTitleMargin: -@headerLineHeightOffset 0em 0em;
@resultTitleMargin: calc(-1 * @headerLineHeightOffset) 0em 0em;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another calc() where I'm not sure if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants