feat(components/atom/input): Improve a11y by wrapping clickable icons in Button with hover state#2933
Open
feat(components/atom/input): Improve a11y by wrapping clickable icons in Button with hover state#2933
Conversation
|
jordevo
reviewed
Sep 26, 2025
Comment on lines
22
to
25
| top: -8px; | ||
| bottom: -8px; | ||
| left: -8px; | ||
| right: -8px; |
Contributor
There was a problem hiding this comment.
should we be using some theme var here...? $m-m or $m-l perhaps?
jordevo
reviewed
Sep 26, 2025
| } | ||
|
|
||
| &-container { | ||
| width: 24px; |
|
|
andresin87
requested changes
Oct 3, 2025
Member
andresin87
left a comment
There was a problem hiding this comment.
not the s-ui button but a unestiled
|
Author
Listo! He cambiado el sui-button per un boton sin estilos pero he mantenido un hover por defecto |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category/Component
❓ AskTASK: MMAA-48558
Description, Motivation and Context
This PR improves the InputIcons component by making icon elements clickable using accessible <Button> elements when click handlers are provided.
Previously, icons were rendered as <span> elements even when onClickLeftIcon or onClickRightIcon were passed, which made them less accessible and provided no hover/focus feedback.
Now:
This change improves accessibility
Types of changes
Screenshots - Animations