Skip to content

Conversation

@samatstariongroup
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the SysML2.NET code style guidelines
  • I have provided test coverage for my change (where applicable)

Description

  • Implemented a CDP4-COMET inspired MessagePack serialization library.
  • Ignored reading.writing derived and redefined properties
  • Payload class has predictable positions for objects and properties (required for MessagePack), where the various Core types are ordered by UML class name (not the whole namespace, let me know if you think the order is fine like this or whether we should sort on whole namespace)

Currently testing is done by reading in a JSON doc, serialize MessagePack to serialize to stream and deserialize. Once comparers as requested in issue #60 are available, tests need to be improved to verify equality of objects between json read and messagepack write -> read

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
71.9% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@samatstariongroup samatstariongroup merged commit 81feb41 into development Jan 26, 2026
7 of 8 checks passed
@samatstariongroup samatstariongroup deleted the GH43-MessagePackSerializer branch January 26, 2026 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants