Modify Message (optional parse_headers) and UnicastPrefixes (optional validation and required_fields)#10
Open
Matvey-Kuk wants to merge 6 commits intoSNAS:masterfrom
Open
Modify Message (optional parse_headers) and UnicastPrefixes (optional validation and required_fields)#10Matvey-Kuk wants to merge 6 commits intoSNAS:masterfrom
Matvey-Kuk wants to merge 6 commits intoSNAS:masterfrom
Conversation
# Conflicts: # src/openbmp/api/parsed/message/Base.py # src/openbmp/api/parsed/message/Message.py # src/openbmp/api/parsed/message/UnicastPrefix.py
…ptional validation and required_fields), validation bug fix
TimEvens
reviewed
Jun 23, 2017
| for record in Base.isplit(data, "\n"): | ||
| fields = record.split('\t') # Fields of a record as array. | ||
|
|
||
| fields_map = {} |
Contributor
There was a problem hiding this comment.
Looks like your conflict merge reverted changes that should be here. Please check your merge conflict changes and correct here.
Contributor
Author
There was a problem hiding this comment.
@TimEvens isn't it what I moved to lines 117-122? I don't see anything missing.
Contributor
Author
There was a problem hiding this comment.
And it's tested in "tests/test_unicast_prefix.py"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parse UnicastPrefix faster without validation or even exclude some unnecessary fields. Unit tests for new features provided.