Light Calorimetry: add sim energy deposit info and light calo info into cafs #619
Conversation
|
@lynnt20 could you nominate reviewers please? |
sbncode v10_14_02 for larsoft v10_14_02
linyan-w
moved this from Expected for Later
to Waiting on Reviewer
in SBND 2025 Fall Production
|
@PetrilloAtWork would you mind taking a look at this PR? It's the last of the light calorimetry stack of PRs 😃 Thank you advance! |
sbncode v10_14_02_01 for larsoft v10_14_02_01
henrylay97
left a comment
henrylay97
left a comment
There was a problem hiding this comment.
Looking really good. Couple of small queries before I approve :D
| Atom<art::InputTag> SimEnergyDepositLabel { | ||
| Name("SimEnergyDepositLabel"), | ||
| Comment("Label of input sim::SimEnergyDeposit objects."), | ||
| art::InputTag("ionandscint", "priorSCE","G4") |
There was a problem hiding this comment.
What's the motivation for explicitly naming the process name as "G4"? Are we expecting scenarios where multiple fcl processes have created SimEnergyDeposits? Definitely not asking for a change here as this is nice and fcl flexible. Just interested in why this came up!
There was a problem hiding this comment.
Hmm, no particular reason. I think I had paralleled the syntax for the trigger emulation in the same file!
|
|
||
| srtruthbranch.dep.reserve(mctruths.size()); | ||
| for (size_t n=0; n<mctruths.size();n++){ | ||
| SRTrueDeposit init; |
There was a problem hiding this comment.
Is the name SRTrueDeposit a little confusing when the object is actually going to store the sum of all relevant deposits? I wonder whether we want to call it something like SRTotalTrueDeposition or something catchier you can think of? Maybe this isn't a problem 🤔 🤷
There was a problem hiding this comment.
I could go either way about it, not sure that I feel very strongly as long as you think it's documented well in the corresponding header. It may be confusing if one expects it to be exactly what's in SimEnergyDeposits, but I think what the branch is actually accessible with (which is rec.mc.dep.energy, etc., is not too bad?
Description
Adds info from
SimEnergyDepositsand light calorimetry into cafmaker.SBND is currently keeping
SimEnergyDepositsthroughout the workflow. We can take better advantage of this information (truth level number of electrons, photons, and true energy deposits for true neutrino interactions) by adding it to the cafs in a new class calledSRTrueDeposit. Default will be empty if noSimEnergyDeposits are available in the input files. Only adds 3 floats per neutrino interaction (obtained from length ofMCTruth).Accompanying PRs: SBNSoftware/sbndcode#878, SBNSoftware/sbnanaobj#181, SBNSoftware/sbnobj#158