Skip to content

minimal-versions: replace workspace Cargo.toml instead of deleting #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tarcieri merged 3 commits into from
Jan 21, 2026
Merged

minimal-versions: replace workspace Cargo.toml instead of deleting #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
64a713b
minimal-versions: replace workspace Cargo.toml instead of deleting
tarcieri Jan 20, 2026
a1ceb2c
disable yamllint line length lint
tarcieri Jan 21, 2026
dbf4554
Update .github/workflows/minimal-versions.yml
tarcieri Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/minimal-versions.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,8 @@ jobs:
- uses: dtolnay/rust-toolchain@master
with:
toolchain: ${{ inputs.nightly }}
- run: rm ../Cargo.toml
# Use a stub Cargo.toml at the workspace-level which still allows workspace-level configs to function
- run: printf "[workspace]\nmembers=[\"%q\"]" $(pwd) >> ../Cargo.toml
- run: cargo update -Z minimal-versions
- run: ${{ inputs.nightly-cmd }}
# Perform tests
Expand Down
2 changes: 2 additions & 0 deletions .yamllint.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
rules:
line-length: disable
Copy link
Member

@newpavlov newpavlov Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC it's possible to split run commands into multiple lines.

Copy link
Member Author

@tarcieri tarcieri Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather not have to debug syntax issues in YAML configuration files because some lint is telling me every line must be 80 characters long, which is a silly restriction to begin with