Adds window size and position assertions for MacOS#925
Adds window size and position assertions for MacOS#925mnmaita wants to merge 1 commit intoRust-SDL2:masterfrom
Conversation
|
For the first one, you can have a
Otherwise it looks good to me. The alternative would be to output a |
|
@Cobrand Thank you for your guidelines. I want to output a |
|
@mnmaita Sorry for the late response. Breaking API changes make sense if there is a valid reason behind it, and this is a perfectly valid reason. |
|
No problem @Cobrand, I'm very busy lately but I'll get to this soon. |
This PR tries to address Issue #700 .
Remarks:
I'd like to get rid of the magic numbers here and create constants for these boundaries, what would be the best way to do this?
I've added custom messages to the assertions, I don't know if this is desirable or not.
Big plus, a MacOS system user that's able to test this would be awesome 😄.