Open
Conversation
Owner
|
In case you're wondering why this is still sitting! I checked it |
Owner
|
Ugh sorry on my phone and hit the "close and comment" button by accident as I was typing my comment 🤪 Anyway: I checked the branch out and was looking at this plus your other pull request and because of the nested loop situation I was going to see if I could make some optimizations before merging. But I haven't actually had a lot of time to dig deeply, thus this PR sits here until I have the chance! 😃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yet another small edge case bug I found: Italic text spanning a newline does not generate valid markdown.
Example:

Currently, this results in markdown like this
Rendering this will show underscores instead of italic text.
(Interestingly, I just found that GitHub suffers under the very same issue. 😆)
To fix this, we can split all open inline style and entity ranges when hitting a
\ncharacter. So now, the markdown produced for this example looks as follows