Mitigate compiler warnings #1385
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR narrows the Node.js header inclusion in the native bindings to only pull in version macros, which helps mitigate compiler warnings from unnecessary Node C++ API exposure.
Changes:
- Replace the broad
<node.h>include with the more targeted<node_version.h>inrcl_bindings.cpp. - Continue to use
NODE_MAJOR_VERSION,NODE_RUNTIME_ELECTRON, andNODE_MODULE_VERSIONmacros via the new header to guard behavior inCreateArrayBufferFromAddress.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR narrows the Node.js header inclusion in the native bindings to only pull in version macros, which helps mitigate compiler warnings from unnecessary Node C++ API exposure.
Changes:
<node.h>include with the more targeted<node_version.h>inrcl_bindings.cpp.NODE_MAJOR_VERSION,NODE_RUNTIME_ELECTRON, andNODE_MODULE_VERSIONmacros via the new header to guard behavior inCreateArrayBufferFromAddress.Fix: #1385