Re-enable rolling build on Windows #1382
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the URL for downloading ROS2 Rolling binaries on Windows, changing from the old ci.ros2.org build farm to the newer GitHub releases location. The title suggests this is meant to "re-enable" rolling builds on Windows.
Changes:
- Updated the wget URL from
ci.ros2.org/view/packaging/job/packaging_windows/lastSuccessfulBuild/artifact/ws/ros2-package-windows-AMD64.ziptogithub.com/ros2/ros2/releases/download/release-rolling-nightlies/ros2-rolling-nightly-windows-amd64.zip
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| shell: bash | ||
| run: | | ||
| wget --quiet https://ci.ros2.org/view/packaging/job/packaging_windows/lastSuccessfulBuild/artifact/ws/ros2-package-windows-AMD64.zip -O rolling.zip | ||
| wget --quiet https://github.com/ros2/ros2/releases/download/release-rolling-nightlies/ros2-rolling-nightly-windows-amd64.zip -O rolling.zip |
There was a problem hiding this comment.
The PR title indicates this change is meant to "Re-enable rolling build on Windows", but the 'rolling' distribution is not included in the matrix (lines 18-21 only list humble, jazzy, and kilted). This means the conditional step on line 39 will never execute, and the URL change will have no effect.
To actually enable the rolling build, 'rolling' needs to be added to the ros_distribution matrix. For reference, the Linux x64 workflow (linux-x64-build-and-test.yml) includes 'rolling' in its matrix at line 29.
2 participants
This PR updates the URL for downloading ROS2 Rolling binaries on Windows, changing from the old ci.ros2.org build farm to the newer GitHub releases location. The title suggests this is meant to "re-enable" rolling builds on Windows.
Changes:
ci.ros2.org/view/packaging/job/packaging_windows/lastSuccessfulBuild/artifact/ws/ros2-package-windows-AMD64.ziptogithub.com/ros2/ros2/releases/download/release-rolling-nightlies/ros2-rolling-nightly-windows-amd64.zipFix: #1383