Ensure type hinting for the parameter is set to float#16
Open
dezertdezine wants to merge 1 commit intoRichardds:masterfrom
Open
Ensure type hinting for the parameter is set to float#16dezertdezine wants to merge 1 commit intoRichardds:masterfrom
dezertdezine wants to merge 1 commit intoRichardds:masterfrom
Conversation
Richardds
requested changes
Mar 1, 2023
| * @param float $amount | ||
| * @param string|array $currency_code | ||
| * @param int|null $round | ||
| * @return int|array |
Owner
There was a problem hiding this comment.
Please also change the function return type (incl. docblock). Same in convert and toForeign please.
Owner
|
Hello @dezertdezine , Richard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type hinting for the amount parameter has been changed to float in the following methods:
toEuro
convert
toForeign