Skip to content

build!: use node 24#137

Open
stiefeljackal wants to merge 2 commits intoRetroAchievements:mainfrom
stiefeljackal:build/use-node-24
Open

build!: use node 24#137
stiefeljackal wants to merge 2 commits intoRetroAchievements:mainfrom
stiefeljackal:build/use-node-24

Conversation

@stiefeljackal
Copy link
Contributor

This PR aims to update the version of Node to 24.

Resolves #136

@stiefeljackal stiefeljackal marked this pull request as draft February 4, 2026 23:36
@stiefeljackal
Copy link
Contributor Author

Switching to draft. I'm going to verify set-version.js since it is throwing an error in the CI.

@stiefeljackal
Copy link
Contributor Author

Starting with Node 22, the assert keyword has been replaced with the with keyword when importing modules of different types such as importing package.json. Because of this, the CI failed to build due to this since it is now running under Node 24.

Additionally, set-version.js has been placed in .prettierignore for the moment due to Prettier 2.x.x disliking the with keyword. This has been addressed in Prettier 3.x.x; however, since that is a new major version, I have opted to just ignore the file for now to avoid breaking the prettier format pipeline. set-version.js is small in size and not often touched, so it should be okay to ignore for now.

@stiefeljackal stiefeljackal marked this pull request as ready for review February 5, 2026 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Node 20 End-of-Life

1 participant