Update to react-native and react-native-windows 0.42#53
Update to react-native and react-native-windows 0.42#53ryanlntn wants to merge 8 commits intoReactWindows:masterfrom
Conversation
| new RNSendIntentPackage(), | ||
| new LinearGradientPackage(), | ||
| new FBSDKPackage(), | ||
| new CodePush(null, this, BuildConfig.DEBUG), |
There was a problem hiding this comment.
Looks like a lot of duplicate packages in here, did you run react-native link? #Closed
There was a problem hiding this comment.
@rozele I guess I must have. I must have missed that in all the noise from applying the gitignore. #Closed
| import com.burnweb.rnsendintent.RNSendIntentPackage; | ||
| import com.BV.LinearGradient.LinearGradientPackage; | ||
| import com.facebook.reactnative.androidsdk.FBSDKPackage; | ||
| import com.microsoft.codepush.react.CodePush; |
windows/F8v2/MainPage.cs
Outdated
| { | ||
| #if !PRODFBAPP | ||
| private const string F8AppID = "100794426989995"; | ||
| private const string F8AppID = "223301094807367"; |
There was a problem hiding this comment.
223301094807367 [](start = 44, length = 15)
I think we should hold off on this change for now, it's probably not a good idea to check in these app IDs anyway... #Closed
|
🕐 |
| "react-native-share": "^1.0.11", | ||
| "react-native-windows": "^0.28.1", | ||
| "react-native-share": "ryanlntn/react-native-share#update-0.42", | ||
| "react-native-windows": "0.42.0-rc.0", |
There was a problem hiding this comment.
Is this out for PR? Any chance this is going to be merged?
There was a problem hiding this comment.
PR for react-native-share: react-native-share/react-native-share#109
|
Did you confirm that iOS and Android work? Does it make sense to file a separate PR upstream to fbsamples/f8app to get the app upgraded? |
|
I have not confirmed that iOS and Android work yet. I'll need to get parse setup on OSX to do that. Looking at this open PR I suspect there will be some issues. I don't know how actively fbsamples/f8app is being maintained. It doesn't look like there's been much activity since last summer. |
3 participants
Updates to latest react-native and react-native-windows.