Removes controls option "calcSLDDuringFit"#175
Merged
DrPaulSharp merged 3 commits intoRascalSoftware:mainfrom Aug 7, 2025
Merged
Removes controls option "calcSLDDuringFit"#175DrPaulSharp merged 3 commits intoRascalSoftware:mainfrom
DrPaulSharp merged 3 commits intoRascalSoftware:mainfrom
Conversation
StephenNneji
reviewed
Aug 6, 2025
StephenNneji
reviewed
Aug 6, 2025
cpp/includes/defines.h
Outdated
| adaptPCR : bool | ||
| [DREAM] Whether the crossover probability for differential evolution should be adapted during the run. | ||
| calcSLD : bool | ||
| Whether SLD will be calculated (for live plotting etc.) |
Contributor
There was a problem hiding this comment.
please remove calcSLD from Controls, I think you can safely revert all changes in this file.
cpp/rat.cpp
Outdated
| .def_readwrite("pUnitGamma", &Control::pUnitGamma) | ||
| .def_readwrite("boundHandling", &Control::boundHandling) | ||
| .def_readwrite("adaptPCR", &Control::adaptPCR) | ||
| .def_readwrite("calcSLD", &Control::calcSLD) |
Contributor
There was a problem hiding this comment.
please remove calcSLD from Controls, I think you can safely revert all changes in this file except for line 335
i.e. control_struct.calcSLD = false;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.