Added Bayes benchmark script#105
Merged
alexhroom merged 10 commits intoRascalSoftware:mainfrom Jan 14, 2025
alexhroom:92-orso-tests
Merged
Added Bayes benchmark script#105alexhroom merged 10 commits intoRascalSoftware:mainfrom alexhroom:92-orso-tests
alexhroom merged 10 commits intoRascalSoftware:mainfrom
alexhroom:92-orso-tests
Conversation
DrPaulSharp
reviewed
Dec 18, 2024
Collaborator
Author
|
@DrPaulSharp they both run fine for me, but I may have something weird going on with my binary. what kind of error were you getting? |
DrPaulSharp
reviewed
Jan 13, 2025
Collaborator
DrPaulSharp
left a comment
DrPaulSharp
left a comment
There was a problem hiding this comment.
This looks good now and I have it working, it just needs some updates. Please confirm everything works as expected when they're done.
Collaborator
Author
|
@DrPaulSharp can confirm everything works as expected now |
DrPaulSharp
approved these changes
Jan 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes part of #92 by adding the Bayes benchmark script, which calculates the posterior distributions for a two- and three-dimensional example 'from scratch' and compares them to the distributions generated by the nested sampler and DREAM.
The Python script is mostly similar in workflow to the MATLAB one, but the direct calculation of the posterior is vectorised and the module/function docstrings go into a little more detail on what is actually being done, for users who may not be familiar with the basics of Bayesian reflectivity analysis.
This PR also fixes a minor issue with the plotting library - the axes on the contour plots were the wrong way around (but then were flipped to be correct on corner plots)!