Rewrite game origin icon system to be modular#39
Draft
ihatecompvir wants to merge 11 commits intomasterfrom
Draft
Rewrite game origin icon system to be modular#39ihatecompvir wants to merge 11 commits intomasterfrom
ihatecompvir wants to merge 11 commits intomasterfrom
Conversation
Contributor
|
Having a peek at the decomp, the MusicLibrary class does seem to have an OnExit() function, but this is only for leaving a session and going to the home menu. OnUnload() seems a bit more promising, as it removes the song scores, sorts, and setlists. InitData() also looks promising for a load point, since that’s where it loads in the materials that the library uses. |
Contributor
|
Crossposting the fixed xbox milo from my pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrites the game origin icon system to be far more modular/dynamic and removes the reliance on a special font and a hardcoded list of game origins. Game origin icons (in .png_xbox/wii format) will now be loaded from the ARK path
ui/resource/game_origins/genautomatically. The images must be named the same as a game origin, so a game origin ofrb3will try to loadui/resource/game_origins/gen/rb3.png_<platform>.What still needs to be done before this can be merged:
game-origin-rewritebranch needs to be brought up to speed as it is outdated by over a year