Skip to content

Conversation

@n13
Copy link
Collaborator

@n13 n13 commented Feb 3, 2026

fix ranks and king of the shill display

Simulator Screenshot - iPhone 17 - 2026-02-03 at 13 56 01 Simulator Screenshot - iPhone 17 - 2026-02-03 at 13 56 50

@n13
Copy link
Collaborator Author

n13 commented Feb 3, 2026

Son of Adam review

[16 tools called]

The PR N13/add rank display looks solid. Here is my review:

Summary

The PR successfully implements rank display for both the "King of the Shill" raid and the Referral program. It introduces new models (RaidStats, ReferralRank) and updates the TaskmasterService to fetch this data. The UI in KingOfTheShillScreen and ReferralsQuestScreen has been updated to display the new data.

Highlights

  • Refactoring: The introduction of _authenticatedGet in TaskmasterService is excellent. It significantly reduces code duplication (DRY) and standardizes error handling for authenticated requests.
  • Modern Dart: The use of the null-aware element ?icon in card_info.dart is a nice touch, leveraging modern Dart features for cleaner list construction.
  • UI Updates: The UI changes correctly handle loading states and display the rank/impressions data as requested.

Suggestions

  • Logging: In TaskmasterService, there are several print statements (e.g., print('Error fetching data from $uri: $e');). Since quantus_sdk depends on Flutter, consider using debugPrint instead. debugPrint is generally preferred in Flutter as it handles long output better and can be more easily managed/stripped in production builds.

Verification

  • Version: The pubspec.yaml version bump to 1.1.5+67 is correct.
  • Lints: No linter errors were found in the changed files.

Verdict: Approved. The code is clean, functional, and follows the project's standards.

@n13 n13 merged commit ab4c8c4 into main Feb 3, 2026
1 check passed
@n13 n13 deleted the n13/add_rank_display branch February 3, 2026 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants