Skip to content

Mooncake rules refactor#173

Draft
lkdvos wants to merge 10 commits intomainfrom
ld-mooncake2
Draft

Mooncake rules refactor#173
lkdvos wants to merge 10 commits intomainfrom
ld-mooncake2

Conversation

@lkdvos
Copy link
Member

@lkdvos lkdvos commented Feb 6, 2026

This is a somewhat substantial refactor of the Mooncake rules, that consists of the following changes:

  • I refactored quite a bit of the functions to make more use of broadcasting etc, such that more of the code can be shared. Most implementations now look almost exactly the same.
  • I removed the specialized in-place versions to simply dispatch to the non-mutating ones

This still needs a bit of work to finish up:

  • Verify that the number of allocations/performance of the in-place versions is reasonable
  • Fix the svd_full pullback implementation (see also SVD pullback of rank-deficient matrix #150)
  • Possibly simplify some of the test logic

@lkdvos lkdvos marked this pull request as draft February 6, 2026 20:06
@lkdvos lkdvos requested review from Jutho and kshyatt February 6, 2026 20:06
@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

❌ Patch coverage is 70.58824% with 25 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...gebraKitMooncakeExt/MatrixAlgebraKitMooncakeExt.jl 70.58% 25 Missing ⚠️
Files with missing lines Coverage Δ
...gebraKitMooncakeExt/MatrixAlgebraKitMooncakeExt.jl 72.04% <70.58%> (+11.28%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant