Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the type annotations for the send() method in the Q7 B01 device trait to accurately reflect the types accepted by the underlying send_decoded_command function.
- Updates
send()method signature to useCommandTypeandParamsTypeinstead of more restrictive types - Adds necessary imports for
CommandTypeandParamsTypefromb01_channel
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
allenporter
approved these changes
Dec 24, 2025
Contributor
Done in 3.21.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make the typing accurate for q7 send
Would be great if this could be included in the version bump you are doing on core