fix: Fix diagnostic data redaction to use camelized keys#669
Merged
allenporter merged 1 commit intoPython-roborock:mainfrom Dec 14, 2025
Merged
fix: Fix diagnostic data redaction to use camelized keys#669allenporter merged 1 commit intoPython-roborock:mainfrom
allenporter merged 1 commit intoPython-roborock:mainfrom
Conversation
The redaction list doesn't have the right format for some of the keys.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the diagnostic data redaction mechanism where three keys were using snake_case format instead of camelCase, preventing them from being properly redacted.
- Updates redaction keys to use camelCase format to match the serialization format produced by
as_dict() - Ensures large binary blobs (
imageContent,mapData,rawApiResponse) are properly redacted in diagnostic outputs - Aligns the key format with other multi-word keys in the redaction list (e.g.,
localKey)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Lash-L
approved these changes
Dec 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The redaction list doesn't have the right format for some of the keys.