fix: Additional device logging improvements#668
Merged
allenporter merged 3 commits intoPython-roborock:mainfrom Dec 14, 2025
Merged
fix: Additional device logging improvements#668allenporter merged 3 commits intoPython-roborock:mainfrom
allenporter merged 3 commits intoPython-roborock:mainfrom
Conversation
The logging chnages include: (1) Log less of HomeData since it is large, and instead log a short TL;Dr for each device to make it easier to read. We will rely more on diagnostics for this (though this also needs some changes to get there) (2) Remove redudundant local connection logging (done both in v1 channel and local channel) (3) Fix some additional cases not using the device logger (4) Remove an unncessary line that says "Connecting to device" after it has already connected
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors device logging to improve readability and reduce redundancy. The changes replace large HomeData dumps with concise device summaries, consolidate duplicate logging statements, and ensure consistent use of device-specific loggers.
Key changes:
- Added
summary_info()methods toHomeDataProductandHomeDataDevicefor concise logging - Migrated from global logger to device-specific logger in v1_channel
- Removed redundant connection logging statements
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
roborock/data/containers.py |
Adds summary_info() methods to HomeDataProduct and HomeDataDevice for concise device logging |
roborock/devices/device_manager.py |
Replaces verbose HomeData logging with device count and per-device summaries |
roborock/devices/v1_channel.py |
Changes local connection success logging to use device logger instead of global logger |
roborock/devices/local_channel.py |
Removes redundant "Connecting to..." debug log before connection attempt |
roborock/devices/device.py |
Removes misleading "Connecting to device" log that appeared after connection was already established |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Lash-L
approved these changes
Dec 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logging chnages include:
(1) Log less of HomeData since it is large, and instead log a short TL;Dr for each device to make it easier to read. We will rely more on diagnostics for this (though this also needs some changes to get there) (2) Remove redudundant local connection logging (done both in v1 channel and local channel) (3) Fix some additional cases not using the device logger (4) Remove an unncessary line that says "Connecting to device" after it has already connected
Example device discovery line: