fix: add test coverage for a01 traits#649
Merged
allenporter merged 3 commits intoPython-roborock:mainfrom Dec 7, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive test coverage for the a01 device traits (DyadApi and ZeoApi), with tests that document existing bugs to be fixed by PRs #647 and #645. The tests verify current behavior including edge cases and invalid responses.
- Adds tests for DyadApi query_values method with various protocol types
- Adds tests for ZeoApi query_values method with various protocol types
- Tests document known bugs with inline comments (raw value returns, wrong encoding, invalid value handling, unrequested value returns)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Lash-L
previously approved these changes
Dec 7, 2025
Lash-L
approved these changes
Dec 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds test coverage with comments where there are existing bugs fixed by #647 and #645
Issue #623