fix: Catch UnicodeDecodeError when parsing messages#629
Merged
allenporter merged 1 commit intoPython-roborock:mainfrom Dec 4, 2025
Merged
fix: Catch UnicodeDecodeError when parsing messages#629allenporter merged 1 commit intoPython-roborock:mainfrom
allenporter merged 1 commit intoPython-roborock:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a crash caused by UnicodeDecodeError when attempting to decode MQTT messages with invalid UTF-8 bytes. The fix ensures that such messages are properly caught and logged as exceptions rather than causing uncaught errors.
- Adds
UnicodeDecodeErrorto the exception handling in the V1 protocol message decoder - Adds comprehensive test coverage for invalid UTF-8 byte scenarios
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| roborock/protocols/v1_protocol.py | Adds UnicodeDecodeError to the exception tuple when decoding message payloads to prevent crashes from invalid UTF-8 bytes |
| tests/protocols/test_v1_protocol.py | Adds test case test_invalid_unicode() to verify proper exception handling for messages with invalid UTF-8 bytes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Lash-L
approved these changes
Dec 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes this error message:
This will cause invalid mqtt messages to be ignored and not logged. I suspect this is normal when attempting to parse an mqtt message as a map message? Or may indicate another problem we have not yet diagnosed, but still needed.