fix: Fix device feature discovery#603
Merged
allenporter merged 2 commits intoPython-roborock:mainfrom Nov 28, 2025
Merged
Conversation
Ensure that device feature discovery is performed on startup. This fixes disabled traits that depend on feature discovery. The updated test snapshots for `test_v1_device` correctly show the device features being fixed.
Lash-L
approved these changes
Nov 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that device feature discovery is performed on startup. This fixes disabled traits that depend on feature discovery.
The updated test snapshots for
test_v1_devicecorrectly show the device features being fixed. This also fixes an issue in test_device_trait_command_parsing where it was returning the wrong response for the last clean summary record.Addresses issue called out in home-assistant/core#157378