fix: Fix typing issues in new device traits#577
Merged
allenporter merged 1 commit intoPython-roborock:mainfrom Nov 5, 2025
Merged
fix: Fix typing issues in new device traits#577allenporter merged 1 commit intoPython-roborock:mainfrom
allenporter merged 1 commit intoPython-roborock:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors type handling in the Roborock V1 device traits by introducing consistent type annotations. The changes focus on improving type safety for command parameters and adding switch functionality to the Valley Electricity Timer trait.
- Updated
ValleyElectricityTimerTraitto inherit fromRoborockSwitchBasefor consistent switch behavior - Replaced generic
dict[str, Any]type with the more specificParamsTypefor thesendmethod parameter
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| roborock/devices/traits/v1/valley_electricity_timer.py | Adds RoborockSwitchBase inheritance to provide standardized switch interface methods (is_on, enable, disable) |
| roborock/devices/traits/v1/command.py | Updates send method parameter type from dict[str, Any] | None to ParamsType for better type consistency with the protocol layer |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Lash-L
approved these changes
Nov 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update typing for CommandTrait and ValleyElectricityTimer.