chore: disable body-max-line-length#573
Merged
allenporter merged 1 commit intoPython-roborock:mainfrom Oct 27, 2025
Merged
Conversation
Disable the rule that enforces max commit body line length, since i don't think we need it and it is one that always fails for me.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR disables the body-max-line-length commit message linting rule to remove the enforcement of maximum line length in commit body text.
- Adds a new rule configuration to disable
body-max-line-length
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| // Disable the rule that enforces lowercase in subject | ||
| "subject-case": [0], // 0 = disable, 1 = warn, 2 = error | ||
| // Disable the rule that enforces a maximum line length in the body | ||
| "body-max-line-length": [0, "always"] |
There was a problem hiding this comment.
The second parameter 'always' is unnecessary when disabling a rule (level 0). When a rule is disabled, applicability conditions are ignored. Consider simplifying to [0] for consistency with the subject-case rule above.
Suggested change
| "body-max-line-length": [0, "always"] | |
| "body-max-line-length": [0] |
Lash-L
approved these changes
Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable the rule that enforces max commit body line length, since i don't think we need it and it is one that always fails for me.