Update minimim python version to 3.12#568
Closed
allenporter wants to merge 3 commits intoPython-roborock:mainfrom
Closed
Update minimim python version to 3.12#568allenporter wants to merge 3 commits intoPython-roborock:mainfrom
allenporter wants to merge 3 commits intoPython-roborock:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the minimum supported Python version from 3.11 to 3.12 to enable the use of newer typing features available in Python 3.12. The changes ensure consistency across the project configuration and CI/CD pipeline.
Key Changes:
- Updated minimum Python version requirement in package metadata
- Updated CI/CD workflows to use Python 3.12 for all jobs
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pyproject.toml | Updated requires-python field to require Python 3.12+ |
| .github/workflows/ci.yml | Updated Python version in pre-commit, test matrix, and build jobs to 3.12 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
allenporter
force-pushed
the
python-v
branch
2 times, most recently
from
02a5639 to
12a11c9
Compare
Stop supporting python 3.11 and jump to 3.12. The motivation is to be able to use 3.12 typing features
Lash-L
approved these changes
Oct 26, 2025
Contributor
Author
|
This still has some lint errors, moving back to draft since this is not ready yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop supporting python 3.11 and jump to 3.12. The motivation is to be able to use 3.12 typing features