fix: FIx bug in clean record parsing#567
Merged
allenporter merged 1 commit intoPython-roborock:mainfrom Oct 25, 2025
Merged
Conversation
This unpacks the data from the outer list before parsing as another list.
Contributor
There was a problem hiding this comment.
Pull Request Overview
Fixes a bug in clean record parsing where the response data was wrapped in an unnecessary outer list layer, causing parsing failures.
Key Changes:
- Added unwrapping logic to extract data from single-element list wrapper before parsing
- Updated test data structure to reflect the actual wrapped format received from devices
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| roborock/devices/traits/v1/clean_summary.py | Added check to unwrap single-element list before parsing clean record response |
| tests/devices/traits/v1/test_clean_summary.py | Updated test data to include outer list wrapper matching actual device response format |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+56
to
+57
| if isinstance(response, list) and len(response) == 1: | ||
| response = response[0] |
There was a problem hiding this comment.
The unwrapping logic assumes only single-element lists need unwrapping. Consider handling edge cases where response is an empty list or has multiple elements. If these scenarios shouldn't occur, add validation to raise a descriptive error rather than silently proceeding with unexpected data.
Suggested change
| if isinstance(response, list) and len(response) == 1: | |
| response = response[0] | |
| if isinstance(response, list): | |
| if len(response) == 1: | |
| response = response[0] | |
| elif len(response) == 0: | |
| raise ValueError("Received empty list for clean record response; expected a single-element list.") | |
| else: | |
| raise ValueError(f"Received list of length {len(response)} for clean record response; expected a single-element list. Response: {response!r}") |
Lash-L
approved these changes
Oct 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This unpacks the data from the outer list before parsing as another list.