Add a trait for reading NetworkInfo from the device#558
Merged
allenporter merged 2 commits intoPython-roborock:mainfrom Oct 24, 2025
Merged
Add a trait for reading NetworkInfo from the device#558allenporter merged 2 commits intoPython-roborock:mainfrom
allenporter merged 2 commits intoPython-roborock:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new trait for reading network information from Roborock devices. The trait prefers reading from cache to avoid unnecessary RPC calls, since network info is typically already fetched during device discovery. If the cache is not populated, it falls back to querying the device directly.
Key Changes:
- Added
NetworkInfoTraitclass that inherits fromNetworkInfoandV1TraitMixin - Integrated the new trait into the V1 device properties API
- Added CLI command to display network information for a device
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| roborock/devices/traits/v1/network_info.py | Implements the NetworkInfoTrait class with cache-first logic and device fallback |
| roborock/devices/traits/v1/init.py | Integrates NetworkInfoTrait into PropertiesApi and updates the create function signature |
| roborock/devices/device_manager.py | Updates v1.create call to pass device_uid parameter |
| roborock/cli.py | Adds network_info CLI command for displaying device network information |
| tests/devices/traits/v1/test_network_info.py | Tests for NetworkInfoTrait covering cache and device scenarios |
| tests/devices/traits/v1/fixtures.py | Updates device fixture to include device_uid parameter |
| tests/devices/test_v1_device.py | Updates device fixture to include device_uid parameter |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This is mirroring what is done during device discovery, but also allows it to be exposed for the caller to read network information for display purposes. This will always prefer reading from the cache.
4d407a9 to
4bab32b
Compare
Lash-L
approved these changes
Oct 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is mirroring what is done during device discovery, but also allows it to be exposed for the caller to read network information for display purposes. This will always prefer reading from the cache.
The intent is to use this for Home Assistant's device information.