feat: Combine the clean record trait with the clean summary#555
Merged
allenporter merged 3 commits intoPython-roborock:mainfrom Oct 21, 2025
Merged
feat: Combine the clean record trait with the clean summary#555allenporter merged 3 commits intoPython-roborock:mainfrom
allenporter merged 3 commits intoPython-roborock:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR consolidates the clean record functionality into the clean summary trait, simplifying the API by eliminating a separate clean record trait. The change reduces interdependencies and makes it easier to access cleaning data.
- Merged
CleanRecordTraitfunctionality directly intoCleanSummaryTrait - Introduced
CleanSummaryWithDetaildata class to include the last clean record - Removed the separate
CleanRecordTraitclass and its associated files
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| roborock/devices/traits/v1/clean_summary.py | Added clean record fetching methods and refresh logic to CleanSummaryTrait |
| roborock/devices/traits/v1/clean_record.py | Removed entire file containing CleanRecordTrait class |
| roborock/data/v1/v1_containers.py | Added CleanSummaryWithDetail class extending CleanSummary with last_clean_record field |
| roborock/devices/traits/v1/init.py | Removed CleanRecordTrait imports and initialization |
| tests/devices/traits/v1/test_clean_summary.py | Migrated clean record tests and added new test cases |
| tests/devices/traits/v1/test_clean_record.py | Removed entire test file |
| tests/devices/snapshots/test_v1_device.ambr | Updated snapshot to reflect new last_clean_record structure |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This makes the calling code simpler for inspecting cleaning data, and reduces interdependencies between traits exposing internal API details.
bcb7364 to
b083d42
Compare
Lash-L
approved these changes
Oct 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the calling code simpler for inspecting cleaning data, and reduces interdependencies between traits exposing internal API details.