fix: fallback to old version of login#537
Merged
allenporter merged 2 commits intomainfrom Oct 18, 2025
Merged
Conversation
allenporter
reviewed
Oct 17, 2025
Contributor
allenporter
left a comment
There was a problem hiding this comment.
Possible to reproduce the problem with a test?
|
@Lash-L The fall back needs to be moved out of the scope of the login limiter. Other wise it throws rate limit exceptions in the case of a fall back.
I've tested the following change and it works but I am unable to commit to this PR. |
allenporter
approved these changes
Oct 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So I believe what is happening is the following:
Accounts that have not logged in with the newer methods have not been fully migrated. So when we get the information, we only get a country code or a country + a base url.
If we get either one, we can trust that it is a good url. If we get both - we should use code_login_v4, if we just get one, we should use v1.