Add a Home trait that is responsible for caching information about maps and rooms#526
Merged
allenporter merged 4 commits intoPython-roborock:mainfrom Oct 15, 2025
Merged
Conversation
allenporter
force-pushed
the
home-cache
branch
2 times, most recently
from
3835295 to
fa3782a
Compare
This will be updated to also handle map content storage in a followup.
allenporter
force-pushed
the
home-cache
branch
from
fa3782a to
13a1c0a
Compare
Collaborator
|
Out of town this weekend - but will look on Monday! |
Lash-L
requested changes
Oct 14, 2025
Comment on lines
+151
to
+152
| if current_map_flag is None or self._home_cache is None: | ||
| return None |
Collaborator
There was a problem hiding this comment.
might be good to do some explicit if current_map_flag is 63 checking. But maybe not worth the hastle as it theoretically should be covered.
Contributor
Author
There was a problem hiding this comment.
I think this is checked by status trait given your previous change and will return None? if that is not the case let me know.
Collaborator
|
Looking good - a few quick comments |
allenporter
force-pushed
the
home-cache
branch
from
ce72f8e to
761c4cb
Compare
Lash-L
approved these changes
Oct 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This handles "discovery" of doing a pass through all the maps for initial population. After that, it will only update information for the active maps. This is largely pulling existing home assistant logic into this library, but will improve metadata caching so we can avoid doing discovery on every startup (a feature we've wanted for awhile).
This will be updated to also handle map content storage in a followup.