Add a v1 device trait for map contents#517
Merged
allenporter merged 7 commits intoPython-roborock:mainfrom Oct 5, 2025
Merged
Conversation
allenporter
force-pushed
the
map-content
branch
from
3b62c40 to
7aa408c
Compare
Contributor
Author
|
Whoops, accidentally merged this with the other outstanding PR |
allenporter
force-pushed
the
map-content
branch
from
12532cd to
77570c8
Compare
allenporter
force-pushed
the
map-content
branch
from
77570c8 to
b9ffd65
Compare
This uses the map parser library to return an image and the parsed data from a call.
allenporter
force-pushed
the
map-content
branch
from
b9ffd65 to
023c06c
Compare
Collaborator
|
@allenporter is this one still draft? Looks like you fixed it |
Contributor
Author
|
yes, fixed merged conflicts, this is ready to go, thanks. |
Lash-L
approved these changes
Oct 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a v1 device trait for map contents
This uses the map parser library to return an image and the parsed data from from get v1 maps API. Internally, a new RPC channel is added that is configured to properly encode and parse map responses. Two new CLI options are added for exercising the image content and map metadata functionality.