Conversation
|
🤖 Hi @Lash-L, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
This pull request adds support for the A01 device protocol. The overall structure is good and follows the existing patterns for other protocols. However, the client implementation for the new protocol is incomplete, which is a critical issue that needs to be addressed.
🔍 General Feedback
- The use of a factory pattern in
RoborockApiClientis a good choice for handling multiple protocols. - The tests for the API client are well-written and cover the new protocol.
- There is some code duplication in the CLI that can be refactored for better maintainability.
allenporter
reviewed
Oct 4, 2025
Contributor
allenporter
left a comment
allenporter
left a comment
There was a problem hiding this comment.
Looks good overall. Since i merged, there is now a merge conflict.
Collaborator
Author
|
should be good for another look now that it is merged |
allenporter
approved these changes
Oct 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More can/ will come later. Need to nail down exactly what all of these parameters mean.