feat: add support for getting and reseting consumables#502
feat: add support for getting and reseting consumables#502allenporter merged 3 commits intoPython-roborock:mainfrom
Conversation
Lash-L
left a comment
There was a problem hiding this comment.
Different devices have different consumables - how can we adapt this as needed?
Theoretically, when you get the result from the get consumable status you know which ones can be reset. Not sure if it is a needed check or not, just something I wanted to pose
Sounds like a good idea. Is this handled at all today in use in home assistant? (On Mobile and didn't remember seeing it)
Got it, so they're either present or absent once this has been refreshed? Is that the only place this is revealed or also from features? |
Right now it is just handled with a is none check
I'm not sure, I would have to look through the code and see |
filter_work_time, main_brush_work_time,side_brush_work_time, sensor_dirty_time are enabled for all devices filter_element_work_time is enabled if product nickname is Tanos. |
bc9497c to
6873b81
Compare
|
OK. I've added a comment to the class saying that once refreshed you can tell what is supported by checking not none. From a client perspective, from home assistant pov: I'm not sure how annoying this will be in the integration, but it may be ok to just include this on the first refresh of the coordinator, then continue to check for none when setting up sensors. |
6f67480 to
6283189
Compare
Lash-L
left a comment
There was a problem hiding this comment.
I'll do a follow up expanding this with some more . But it looks good for now
Add a trait that reads and writes consumables. Add tests for the protocol parsing snapshot tests and some of the trait tests. Add the commands to the CLI.