chore: Add test coverage of end to end trait parsing from raw responses#482
Merged
allenporter merged 3 commits intoPython-roborock:mainfrom Sep 18, 2025
Merged
chore: Add test coverage of end to end trait parsing from raw responses#482allenporter merged 3 commits intoPython-roborock:mainfrom
allenporter merged 3 commits intoPython-roborock:mainfrom
Conversation
Lash-L
changed the title
Lash-L
reviewed
Sep 16, 2025
Lash-L
previously approved these changes
Sep 16, 2025
Collaborator
Lash-L
left a comment
Lash-L
left a comment
There was a problem hiding this comment.
Just had that one change
Contributor
Author
|
Fixed lint errors, please take a look. |
Lash-L
approved these changes
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add v1 trait test coverage using the .json files. The existing tests are not testing the full logic from decoding all the way to trait parsing. This at least uses both the logic in
decode_rpc_responseand the actual payload parsing logic in the trait.