chore: remove dependencies on get_request_id by changing where RequestMessage request_id is set#452
Merged
allenporter merged 1 commit intoPython-roborock:mainfrom Aug 18, 2025
Conversation
Lash-L
reviewed
Aug 18, 2025
| raise RoborockException("Got no rriot data from user_data") | ||
| security_data = create_security_data(rriot) | ||
| RoborockMqttClient.__init__(self, user_data, device_info) | ||
| security_data = create_security_data(rriot) |
Collaborator
There was a problem hiding this comment.
If we are using this in the base class, why define it below as well?
Contributor
Author
There was a problem hiding this comment.
It's not setting it as a member in the base class, its just used for some diagnostics, so setting it here so it can be accessed below. Ideally it wouldn't be in the base class given that it's only used in one type of subclass.
Collaborator
|
Need to shave off two characters for commit lint when merging. I'm fine with also increasing the length, I don't think that should break anything with semantic |
allenporter
force-pushed
the
request-message
branch
from
698707f to
f2cd7c6
Compare
Lash-L
approved these changes
Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove some of the payload encoding abstractions so that we don't need to do a round trip for getting
request_id. We can just get it directly when it is assigned to the outgoing message.In a follow up change we will remove
get_request_idfromRoborockMessagewhere the last dependency is in the new mqtt API. This can set us up for making the mqtt channel more appropriate to use for b01 where it doesn't depend on v1 and a01 request id semantics.