Extract common module for managing pending RPCs#451
Merged
allenporter merged 1 commit intoPython-roborock:mainfrom Aug 18, 2025
Merged
Extract common module for managing pending RPCs#451allenporter merged 1 commit intoPython-roborock:mainfrom
allenporter merged 1 commit intoPython-roborock:mainfrom
Conversation
Lash-L
reviewed
Aug 18, 2025
Comment on lines
+44
to
+45
| else: | ||
| _LOGGER.debug("Received unsolicited message: %s", key) |
Collaborator
There was a problem hiding this comment.
So for B01 - this is going to debug for every message we receive. Probably fine, but may be a bit of log spam for users when they turn on debug mode. Probably not that impactful though
Contributor
Author
There was a problem hiding this comment.
OK, we can it use an mqtt channel that does not use this. I think i want to move this out into the v1 rpc channel.
Lash-L
approved these changes
Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract common module for managing pending RPCs. The logic may move elsewhere in follow up PRs.