Conversation
allenporter
requested changes
Aug 14, 2025
Lash-L
commented
Aug 14, 2025
allenporter
reviewed
Aug 21, 2025
Contributor
allenporter
left a comment
allenporter
left a comment
There was a problem hiding this comment.
Generally looks fine, just a question
roborock/containers.py
Outdated
| @dataclass | ||
| class RoborockBase: | ||
| _ignore_keys = [] # type: ignore | ||
| _registry: ClassVar[dict[str, type["RoborockBase"]]] = {} |
Contributor
There was a problem hiding this comment.
what is this needed for?
Collaborator
Author
There was a problem hiding this comment.
It's part of the fix to get roborockbase working on objects not in containers.py
Open to other solutions as well
Contributor
There was a problem hiding this comment.
What does it do and how does it work?
I think just removing from __future__ import annotations from that file will make things work.
Collaborator
Author
There was a problem hiding this comment.
Believe you are correct. Annotations must have been there before and this fixed it while it was. This works without registry now though so I deleted it
allenporter
approved these changes
Aug 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think the next step is to make a B1Channel that does the decoding and handles things for the device? I would like your opinion, as B01 does not have response matching.