feat: add a new type for supported features#431
Merged
allenporter merged 1 commit intomainfrom Aug 10, 2025
Merged
Conversation
allenporter
reviewed
Aug 10, 2025
| TANOSS_FEATURES = NEW_DEFAULT_FEATURES + [ProductFeatures.MOP_SHAKE_MODULE] | ||
| TOPAZSPOWER_FEATURES = NEW_DEFAULT_FEATURES + [ProductFeatures.MOP_SHAKE_MODULE] | ||
|
|
||
| product_feature_map = { |
Collaborator
Author
There was a problem hiding this comment.
Off my machine and on my phone, can do tomorrow 👍🏻
Contributor
|
Just an idea, we can also consider storing these mappings a configuration file: https://github.com/allenporter/pyrainbird/blob/main/pyrainbird/resources/models.yaml (I inherited this code base, not by creation) |
allenporter
approved these changes
Aug 10, 2025
Contributor
allenporter
left a comment
allenporter
left a comment
There was a problem hiding this comment.
Let's handle in a followup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Got these while trying to nail down a better way to fix all the errors with incorrect names for modes or smart mode errors.
This theoretically should make it so we can more dynamically create mop/fan modes. TBD though.
Open to better naming if you can think of it.