feat: Update the cli cache to also store network info#427
Merged
allenporter merged 3 commits intoPython-roborock:mainfrom Aug 10, 2025
Merged
feat: Update the cli cache to also store network info#427allenporter merged 3 commits intoPython-roborock:mainfrom
allenporter merged 3 commits intoPython-roborock:mainfrom
Conversation
Collaborator
|
I think it makes sense to find a way to update the home data - although I guess the user could simply delete their cache manually But home_data is stored, so if a user got a new device, they need to get the new home_data |
Lash-L
previously approved these changes
Aug 10, 2025
A follow up step will support caching network info for the new device manager API, and will use the CLI to do this.
64a1e16 to
82595ee
Compare
Lash-L
approved these changes
Aug 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows using the CLI to talk to local devices without connecting to the server at all once local device information has been cached. A follow up step will support caching network info for the new device manager API, and will use the CLI to do this.
Additional improvements:
~/.roborockfile easier to read by dumping with indent