Skip to content

update kmeans docstring, add counts to algos#121

Open
70Gage70 wants to merge 2 commits intoPyDataBlog:masterfrom
70Gage70:docs-update
Open

update kmeans docstring, add counts to algos#121
70Gage70 wants to merge 2 commits intoPyDataBlog:masterfrom
70Gage70:docs-update

Conversation

@70Gage70
Copy link

Expanded docstring of kmeans function to give a simple example. This was the first thing I checked when I started to use the package and didn't see one.

I also noticed that the algos don't return counts. I just applied the countmap function from StatsBase which we already depend on.

Killer package by the way, it sped up my calculation by an order of magnitude.

@PyDataBlog
Copy link
Owner

Expanded docstring of kmeans function to give a simple example. This was the first thing I checked when I started to use the package and didn't see one.

I also noticed that the algos don't return counts. I just applied the countmap function from StatsBase which we already depend on.

Killer package by the way, it sped up my calculation by an order of magnitude.

Thanks for looking into this and glad that you like the package :)

I will review and looking forward to it eventually going in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants