Fix unorderable types error when sorting slow tests#1
Open
Conversation
Part, where slow tests are printed, where not cevered with tests. Added tests
for that.
In rare cases, when time of two test cases are the same, sorted function lookes
to the next element of tuple, and next element is test instance which is not
orderable. And that rare case it gives following error:
Traceback (most recent call last):
File "CoverageTestRunner.py", line 312, in <module>
run()
File "CoverageTestRunner.py", line 303, in run
result = runner.run()
File "CoverageTestRunner.py", line 265, in run
for secs, test in sorted(result.timings)[-10:]:
TypeError: unorderable types: FooTests() < FooTests()
The fix was to always sort only by time, not by whole tuple.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part, where slow tests are printed, where not cevered with tests. Added tests
for that.
In rare cases, when time of two test cases are the same, sorted function lookes
to the next element of tuple, and next element is test instance which is not
orderable. And that rare case it gives following error:
The fix was to always sort only by time, not by whole tuple.