-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Lowercase and rename langs #1378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can you review? PraaneshSelvaraj |
PraaneshSelvaraj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have one question around the language naming consistency.
For language_id = 1 (ja-hrkt), some localized names explicitly mention hiragana and katakana (for example Giapponese hiragana e katakana, Japanese hiragana and katakana), while others simply use the generic equivalent of “Japanese” (Japonais, Japanisch, Japanese, etc.).
Since we also have language_id = 11 (ja) representing plain Japanese, I just wanted to check what the intended distinction is here. Should ja-hrkt ideally be described as hiragana and katakana across all languages for consistency, or is the current mix intentional?
|
Yeah, better to specify for id |
|
A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data. |
|
The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data. |
No description provided.