Skip to content

Conversation

@Naramsim
Copy link
Member

No description provided.

@Naramsim
Copy link
Member Author

Can you review? PraaneshSelvaraj

Copy link
Contributor

@PraaneshSelvaraj PraaneshSelvaraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one question around the language naming consistency.

For language_id = 1 (ja-hrkt), some localized names explicitly mention hiragana and katakana (for example Giapponese hiragana e katakana, Japanese hiragana and katakana), while others simply use the generic equivalent of “Japanese” (Japonais, Japanisch, Japanese, etc.).

Since we also have language_id = 11 (ja) representing plain Japanese, I just wanted to check what the intended distinction is here. Should ja-hrkt ideally be described as hiragana and katakana across all languages for consistency, or is the current mix intentional?

@Naramsim
Copy link
Member Author

Naramsim commented Jan 21, 2026

Yeah, better to specify for id 1 that should be only hiragana and katakana. I'll come up with some translations

@Naramsim Naramsim merged commit 6d52df7 into master Jan 22, 2026
9 checks passed
@pokeapi-machine-user
Copy link

A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and the entire API will be ready to review.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

@pokeapi-machine-user
Copy link

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

The Pull Request can be seen deployed in our staging environment when CircleCI deploy will be finished (check the start time of the last build).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants