Remove local source copied zlib files #6399
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using system installed zlib.
…causes a out-of-vector bound if its cleared. Example works afterwards.
larshg
force-pushed
the
removezlibusedinsurfacenurbs
branch
from
75bc47f to
a45d48c
Compare
mvieth
reviewed
Jan 26, 2026
Member
mvieth
left a comment
mvieth
left a comment
There was a problem hiding this comment.
I think I would keep the HAVE_ZLIB preprocessor-define and the WITH_SYSTEM_ZLIB option, and either warn or error-out if WITH_SYSTEM_ZLIB is FALSE. That's a smoother transition for people who use one or the other. And zlib.cmake can probably be removed now?
Keep HAVE_ZLIB - added config include to opennurbs_zlib.cpp. Correctly check for ZLIB for libpng_wrapper as it includes <zlib.h>
Contributor
Author
|
Have updated accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
External zlib has been default and is the preferred usage.