Added fix for basic relative URLs and support variables in servers URLs#69
Open
udamir wants to merge 15 commits intoPayU:masterfrom
Open
Added fix for basic relative URLs and support variables in servers URLs#69udamir wants to merge 15 commits intoPayU:masterfrom
udamir wants to merge 15 commits intoPayU:masterfrom
Conversation
Author
|
This resolves #59 |
kobik
reviewed
Mar 7, 2021
udamir
commented
Mar 8, 2021
Move this improvement to next version
|
+1 on this fix |
Collaborator
|
CI is passing locally, merging. |
kibertoad
approved these changes
Mar 27, 2021
Collaborator
|
@kobik Could you please merge this? |
Author
|
What I need to do to pass ci/circleci checks? |
|
Bump on this change -- anything blocking it besides a review? I can add a commit if needed. |
Collaborator
|
@udamir @goldsziggy This still needs tests, and also conflicts need to be resolved now that https://github.com/PayU/api-schema-builder/pull/67/files is merged, which I believe will be superseded by this PR - but you can definitely reuse the tests that were created for that PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't want to put a specific url of server in OpenAPI file, as it can be used in different environments, so I use the following:
On init method I get the error: