Enable Embedded Mode (on top of auth) #2786
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 16, 2026
mikeminutillo
force-pushed
the
embedded-mode-2
branch
from
ee92ac6 to
bf7b828
Compare
mikeminutillo
force-pushed
the
embedded-mode-2
branch
from
c166214 to
980585c
Compare
PhilBastian
approved these changes
Jan 29, 2026
Comment on lines
+49
to
53
| <span v-if="!isEmbedded && !newVersions.newSPVersion.newspversion && environment.sp_version"> ServicePulse v{{ environment.sp_version }} </span> | ||
| <span v-if="!isEmbedded && newVersions.newSPVersion.newspversion && environment.sp_version"> | ||
| ServicePulse v{{ environment.sp_version }} (<FAIcon v-if="newVersions.newSPVersion.newspversionnumber" class="footer-icon fake-link" :icon="faArrowTurnUp" /> | ||
| <a :href="newVersions.newSPVersion.newspversionlink" target="_blank">v{{ newVersions.newSPVersion.newspversionnumber }} available</a>) | ||
| </span> |
Contributor
There was a problem hiding this comment.
Suggested change
| <span v-if="!isEmbedded && !newVersions.newSPVersion.newspversion && environment.sp_version"> ServicePulse v{{ environment.sp_version }} </span> | |
| <span v-if="!isEmbedded && newVersions.newSPVersion.newspversion && environment.sp_version"> | |
| ServicePulse v{{ environment.sp_version }} (<FAIcon v-if="newVersions.newSPVersion.newspversionnumber" class="footer-icon fake-link" :icon="faArrowTurnUp" /> | |
| <a :href="newVersions.newSPVersion.newspversionlink" target="_blank">v{{ newVersions.newSPVersion.newspversionnumber }} available</a>) | |
| </span> | |
| <template v-else-if="environment.sp_version"> | |
| <span v-if="!newVersions.newSPVersion.newspversion"> ServicePulse v{{ environment.sp_version }} </span> | |
| <span v-else> | |
| ServicePulse v{{ environment.sp_version }} (<FAIcon v-if="newVersions.newSPVersion.newspversionnumber" class="footer-icon fake-link" :icon="faArrowTurnUp" /> | |
| <a :href="newVersions.newSPVersion.newspversionlink" target="_blank">v{{ newVersions.newSPVersion.newspversionnumber }} available</a>) | |
| </span> | |
| </template> |
| } | ||
|
|
||
| private getUrl() { | ||
| if (window.defaultConfig && window.defaultConfig.isEmbedded && window.defaultConfig.service_control_url && window.defaultConfig.service_control_url.length) { |
Contributor
There was a problem hiding this comment.
Suggested change
| if (window.defaultConfig && window.defaultConfig.isEmbedded && window.defaultConfig.service_control_url && window.defaultConfig.service_control_url.length) { | |
| if (window.defaultConfig?.isEmbedded && window.defaultConfig.service_control_url?.length) { |
| service_control_url: '{{settings.ServiceControlUrl}}', | ||
| monitoring_urls: ['{{settings.MonitoringUrl ?? "!"}}'], | ||
| showPendingRetry: {{(settings.ShowPendingRetry ? "true" : "false")}}, | ||
| isEmbedded: {{(settings.IsEmbedded ? "true" : "false")}} |
Contributor
There was a problem hiding this comment.
neater?
Suggested change
| isEmbedded: {{(settings.IsEmbedded ? "true" : "false")}} | |
| isEmbedded: {{(settings.IsEmbedded.ToString().ToLower())}} |
| /// </summary> | ||
| public static ServicePulseSettings GetFromEnvironmentVariables() | ||
| { | ||
| var serviceControlUrl = Environment.GetEnvironmentVariable("SERVICECONTROL_URL") ?? "http://localhost:33333/api/"; |
Contributor
There was a problem hiding this comment.
suggest use of StringBuilder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #2782
Reviewer Checklist